switcherPopup: Factor the initial selection into the base class

Only the application switcher needs to keep its own implementation
since it has two modes of operation depending on the binding.

https://bugzilla.gnome.org/show_bug.cgi?id=735976

diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index b11c4f13f1657cd5a85db3ea3584d1ae13a99d0f..cee81b0e10d13b78ce571d75ac73e6d6d63ac54d 100644 (file)
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -378,15 +378,6 @@ const WindowSwitcherPopup = new Lang.Class({
         return global.display.get_tab_list(Meta.TabList.NORMAL, workspace);
     },
 
-    _initialSelection: function(backward, binding) {
-        if (binding == 'switch-windows-backward' || backward)
-            this._select(this._items.length - 1);
-        else if (this._items.length == 1)
-            this._select(0);
-        else
-            this._select(1);
-    },
-
     _keyPressHandler: function(keysym, action) {
         if (action == Meta.KeyBindingAction.SWITCH_WINDOWS) {
             this._select(this._next());

diff --git a/js/ui/ctrlAltTab.js b/js/ui/ctrlAltTab.js
index 85e39dfbc7a099c4c0d1089c7aef018bb4f8b379..56949907c85a4287e5ac08db57d610ecb131645a 100644 (file)
--- a/js/ui/ctrlAltTab.js
+++ b/js/ui/ctrlAltTab.js
@@ -146,17 +146,6 @@ const CtrlAltTabPopup = new Lang.Class({
         this._switcherList = new CtrlAltTabSwitcher(this._items);
     },
 
-    _initialSelection: function(backward, binding) {
-        if (binding == 'switch-panels') {
-            if (backward)
-                this._selectedIndex = this._items.length - 1;
-        } else if (binding == 'switch-panels-backward') {
-            if (!backward)
-                this._selectedIndex = this._items.length - 1;
-        }
-        this._select(this._selectedIndex);
-    },
-
     _keyPressHandler: function(keysym, action) {
         if (action == Meta.KeyBindingAction.SWITCH_PANELS)
             this._select(this._next());

diff --git a/js/ui/status/keyboard.js b/js/ui/status/keyboard.js
index ea02f6f8fd3a46ad47e1d3d50d62a46df3ad6f6e..4bb92252f6c4a4c62b75b4c25e19af0027c6a60d 100644 (file)
--- a/js/ui/status/keyboard.js
+++ b/js/ui/status/keyboard.js
@@ -269,17 +269,6 @@ const InputSourcePopup = new Lang.Class({
         this._switcherList = new InputSourceSwitcher(this._items);
     },
 
-    _initialSelection: function(backward, binding) {
-        if (binding == 'switch-input-source') {
-            if (backward)
-                this._selectedIndex = this._items.length - 1;
-        } else if (binding == 'switch-input-source-backward') {
-            if (!backward)
-                this._selectedIndex = this._items.length - 1;
-        }
-        this._select(this._selectedIndex);
-    },
-
     _keyPressHandler: function(keysym, action) {
         if (action == this._action)
             this._select(this._next());

diff --git a/js/ui/switcherPopup.js b/js/ui/switcherPopup.js
index c9d3884b947899b15456f139fc0f21123eeb1644..24ad27904cec6da210af3579ad9b41090f1535a4 100644 (file)
--- a/js/ui/switcherPopup.js
+++ b/js/ui/switcherPopup.js
@@ -103,7 +103,12 @@ const SwitcherPopup = new Lang.Class({
     },
 
     _initialSelection: function(backward, binding) {
-        throw new Error('Not implemented');
+        if (backward)
+            this._select(this._items.length - 1);
+        else if (this._items.length == 1)
+            this._select(0);
+        else
+            this._select(1);
     },
 
     show: function(backward, binding, mask) {
@@ -135,11 +140,6 @@ const SwitcherPopup = new Lang.Class({
         this.actor.show();
         this.actor.get_allocation_box();
 
-        if (this._items.length > 1)
-            this._selectedIndex = 1;
-        else
-            this._selectedIndex = 0;
-
         this._initialSelection(backward, binding);
 
         // There's a race condition; if the user released Alt before